On 8/9/25 15:54, Brahmajit Das wrote:
> Replace the use of drm_debugfs_create_files() with the new
> drm_debugfs_add_files() function, which centers the debugfs files
> management on the drm_device instead of drm_minor.
>
> Signed-off-by: Brahmajit Das <listout@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/virtio/virtgpu_debugfs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_debugfs.c b/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> index 853dd9aa397e..b7c895fe5ddc 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> @@ -94,7 +94,7 @@ virtio_gpu_debugfs_host_visible_mm(struct seq_file *m, void *data)
> return 0;
> }
>
> -static struct drm_info_list virtio_gpu_debugfs_list[] = {
> +static struct drm_debugfs_info virtio_gpu_debugfs_list[] = {
> { "virtio-gpu-features", virtio_gpu_features },
> { "virtio-gpu-irq-fence", virtio_gpu_debugfs_irq_info, 0, NULL },
> { "virtio-gpu-host-visible-mm", virtio_gpu_debugfs_host_visible_mm },
> @@ -105,7 +105,6 @@ static struct drm_info_list virtio_gpu_debugfs_list[] = {
> void
> virtio_gpu_debugfs_init(struct drm_minor *minor)
> {
> - drm_debugfs_create_files(virtio_gpu_debugfs_list,
> - VIRTIO_GPU_DEBUGFS_ENTRIES,
> - minor->debugfs_root, minor);
> + drm_debugfs_add_files(minor->dev, virtio_gpu_debugfs_list,
> + VIRTIO_GPU_DEBUGFS_ENTRIES);
> }
drm_debugfs_create_files() uses drm_info_node, while
drm_debugfs_add_files() uses drm_debugfs_entry. This patch looks wrong
and, AFAICT, doesn't improve anything. Hence, let's keep this code as-is
if there is no real benefit from the change.
--
Best regards,
Dmitry
