Re: [PATCH v3] vfio/pci: Do vf_token checks for VFIO_DEVICE_BIND_IOMMUFD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2025 at 01:55:45AM +0300, Dan Carpenter wrote:
> 5fcc26969a164e Yi Liu          2023-07-18  117  	mutex_lock(&device->dev_set->lock);
> 5fcc26969a164e Yi Liu          2023-07-18  118  	/* one device cannot be bound twice */
> 5fcc26969a164e Yi Liu          2023-07-18  119  	if (df->access_granted) {
> 5fcc26969a164e Yi Liu          2023-07-18  120  		ret = -EINVAL;
> 5fcc26969a164e Yi Liu          2023-07-18  121  		goto out_unlock;
> 5fcc26969a164e Yi Liu          2023-07-18  122  	}
> 5fcc26969a164e Yi Liu          2023-07-18  123  
> be2e70b96c3e54 Jason Gunthorpe 2025-07-14  124  	ret = vfio_df_check_token(device, &bind);
> be2e70b96c3e54 Jason Gunthorpe 2025-07-14  125  	if (ret)
> be2e70b96c3e54 Jason Gunthorpe 2025-07-14 @126  		return ret;
> 
> This needs to be a goto unlock.

Oop yes, thank you

Alex can you fix it up when applying?

Thanks,
Jason




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux