Re: [PATCH RFC v4 2/5] virtio: fix comments, readability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 3, 2025 at 5:26 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> Fix a couple of comments to match reality.
> Initialize config_driver_disabled to be consistent with
> other fields (note: the structure is already zero initialized,
> so this is not a bugfix as such).
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Thanks

> ---
>  drivers/virtio/virtio.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 95d5d7993e5b..c441c8cc71ef 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -147,7 +147,7 @@ EXPORT_SYMBOL_GPL(virtio_config_changed);
>
>  /**
>   * virtio_config_driver_disable - disable config change reporting by drivers
> - * @dev: the device to reset
> + * @dev: the device to disable
>   *
>   * This is only allowed to be called by a driver and disabling can't
>   * be nested.
> @@ -162,7 +162,7 @@ EXPORT_SYMBOL_GPL(virtio_config_driver_disable);
>
>  /**
>   * virtio_config_driver_enable - enable config change reporting by drivers
> - * @dev: the device to reset
> + * @dev: the device to enable
>   *
>   * This is only allowed to be called by a driver and enabling can't
>   * be nested.
> @@ -530,6 +530,7 @@ int register_virtio_device(struct virtio_device *dev)
>                 goto out_ida_remove;
>
>         spin_lock_init(&dev->config_lock);
> +       dev->config_driver_disabled = false;
>         dev->config_core_enabled = false;
>         dev->config_change_pending = false;
>
> --
> MST
>






[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux