Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 19 Jun 2025 21:17:03 +0700 Bui Quang Minh wrote:
> > I think Michael mention he's AFK so while we wait could you fix this
> > kdoc? I'm not sure whether the kdoc is really necessary here, but if
> > you want to keep it you have to document the return value:
> >
> > Warning: drivers/net/virtio_net.c:1141 No description found for return value of 'buf_to_xdp'  
> 
> I want to add kdoc to clarify that the @len must be without virtio 
> header's length. I'll fix it in the next version.

If that's the case I'd personally limit the doc to:

/* Note that @len is the length of received data without virtio header */

but up to you, it's quite subjective.




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux