Hi Michael, Stefan,
> From: Parav Pandit <parav@xxxxxxxxxx>
> Sent: 02 June 2025 08:15 AM
> To: mst@xxxxxxxxxx; stefanha@xxxxxxxxxx; axboe@xxxxxxxxx;
> virtualization@xxxxxxxxxxxxxxx; linux-block@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx; NBU-Contact-Li Rongqing (EXTERNAL)
> <lirongqing@xxxxxxxxx>; Chaitanya Kulkarni <kch@xxxxxxxxxx>;
> xuanzhuo@xxxxxxxxxxxxxxxxx; pbonzini@xxxxxxxxxx;
> jasowang@xxxxxxxxxx; alok.a.tiwari@xxxxxxxxxx; Parav Pandit
> <parav@xxxxxxxxxx>; Max Gurtovoy <mgurtovoy@xxxxxxxxxx>; Israel
> Rukshin <israelr@xxxxxxxxxx>
> Subject: [PATCH v5] virtio_blk: Fix disk deletion hang on device surprise
> removal
>
> When the PCI device is surprise removed, requests may not complete the
> device as the VQ is marked as broken. Due to this, the disk deletion hangs.
>
> Fix it by aborting the requests when the VQ is broken.
>
> With this fix now fio completes swiftly.
> An alternative of IO timeout has been considered, however when the driver
> knows about unresponsive block device, swiftly clearing them enables users
> and upper layers to react quickly.
>
> Verified with multiple device unplug iterations with pending requests in virtio
> used ring and some pending with the device.
>
> Fixes: 43bb40c5b926 ("virtio_pci: Support surprise removal of virtio pci
> device")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Li RongQing <lirongqing@xxxxxxxxx>
> Closes:
> https://lore.kernel.org/virtualization/c45dd68698cd47238c55fb73ca9b4741
> @baidu.com/
> Reviewed-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
> Reviewed-by: Israel Rukshin <israelr@xxxxxxxxxx>
> Signed-off-by: Parav Pandit <parav@xxxxxxxxxx>
>
> ---
> v4->v5:
> - fixed comment style where comment to start with one empty line at start
> - Addressed comments from Alok
> - fixed typo in broken vq check
Did you get a chance to review this version where I fixed all the comments you proposed?
[..]
