* Simon Horman (horms@xxxxxxxxxx) wrote:
> On Sat, Jun 14, 2025 at 12:07:31AM +0100, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > The functions:
> > vringh_abandon_kern()
> > vringh_abandon_user()
> > vringh_iov_pull_kern() and
> > vringh_iov_push_kern()
> > were all added in 2013 by
> > commit f87d0fbb5798 ("vringh: host-side implementation of virtio rings.")
> > but have remained unused.
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>
> Hi David,
>
> With this patch (set) applied vlang flags the following.
> So I guess that xfer_kern can be removed too.
>
> .../vringh.c:887:19: warning: unused function 'xfer_kern' [-Wunused-function]
> 887 | static inline int xfer_kern(const struct vringh *vrh, void *src,
> | ^~~~~~~~~
> .../vringh.c:894:19: warning: unused function 'kern_xfer' [-Wunused-function]
> 894 | static inline int kern_xfer(const struct vringh *vrh, void *dst,
> | ^~~~~~~~~
Oops, thanks - I should have spotted that; I'll check on it and repost.
> Otherwise this looks good to me.
Thanks for the reviews,
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
