On Thu, Jun 5, 2025 at 2:48 AM Dragos Tatulea <dtatulea@xxxxxxxxxx> wrote:
>
> needs_teardown is a device flag that indicates when virtual queues need
> to be recreated. This happens for certain configuration changes: queue
> size and some specific features.
>
> Currently, the needs_teardown state can be incorrectly reset by
> subsequent .set_vq_num() calls. For example, for 1 rx VQ with size 512
> and 1 tx VQ with size 256:
>
> .set_vq_num(0, 512) -> sets needs_teardown to true (rx queue has a
> non-default size)
> .set_vq_num(1, 256) -> sets needs_teardown to false (tx queue has a
> default size)
>
> This change takes into account the previous value of the needs_teardown
> flag when re-calculating it during VQ size configuration.
>
> Fixes: 0fe963d6fc16 ("vdpa/mlx5: Re-create HW VQs under certain conditions")
> Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Reviewed-by: Shahar Shitrit <shshitrit@xxxxxxxxxx>
> Reviewed-by: Si-Wei Liu <si-wei.liu@xxxxxxxxxx>
> Tested-by: Si-Wei Liu<si-wei.liu@xxxxxxxxxx>
> ---
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
Thanks
