On Tue, May 20, 2025 at 01:24:43PM +0200, Paolo Abeni wrote:
> On 5/16/25 12:00 AM, Bobby Eshleman wrote:
> > +tap_prefix() {
> > + sed -e "s/^/${TAP_PREFIX}/"
> > +}
>
> I think there is no need to the tap prefix to the output you intend to
> 'comment out', the kselftest infra should already add the tap prefix
> mark to each line generated by the test,
>
> > +
> > +tap_output() {
> > + if [[ ! -z "$TAP_PREFIX" ]]; then
>
> AFAICS TAP_PREFIX is a not empty string constant, so this function is
> always a no op. If so it should be dropped.
>
> Otherwise LGTM, thanks,
>
> Paolo
>
That sounds good to me. I originally copied that over from
mm/run_vmtests.sh because their they do have an option for disabling TAP
output (if running as non-kselftest)... but I didn't add the knob to do
that here and am not sure when that might be used so might as well
remove it.
I'll go ahead and remove all of the tap style output.
Best,
Bobby
