On Mon, Apr 21, 2025 at 11:46 AM Jason Wang <jasowang@xxxxxxxxxx> wrote: > > On Mon, Apr 21, 2025 at 11:45 AM Jason Wang <jasowang@xxxxxxxxxx> wrote: > > > > On Mon, Apr 21, 2025 at 10:45 AM Cindy Lu <lulu@xxxxxxxxxx> wrote: > > > > > > Introduce a new config knob `CONFIG_VHOST_ENABLE_FORK_OWNER_IOCTL`, > > > to control the availability of the `VHOST_FORK_FROM_OWNER` ioctl. > > > When CONFIG_VHOST_ENABLE_FORK_OWNER_IOCTL is set to n, the ioctl > > > is disabled, and any attempt to use it will result in failure. > > > > I think we need to describe why the default value was chosen to be false. > > > > What's more, should we document the implications here? > > > > inherit_owner was set to false: this means "legacy" userspace may > > I meant "true" actually. MIchael, I'd expect inherit_owner to be false. Otherwise legacy applications need to be modified in order to get the behaviour recovered which is an impossible taks. Any idea on this? Thanks
