On Tue, Apr 8, 2025 at 12:06 AM Mike Christie <michael.christie@xxxxxxxxxx> wrote: > > On 4/7/25 3:17 AM, Michael S. Tsirkin wrote: > > On Fri, Mar 28, 2025 at 06:02:48PM +0800, Cindy Lu wrote: > >> Abstract vhost worker operations (create/stop/wakeup) into an ops > >> structure to prepare for kthread mode support. > >> > >> Signed-off-by: Cindy Lu <lulu@xxxxxxxxxx> > > > > I worry about the overhead of indirect calls here. > > > > We have the wrappers, and only two options, > > why did you decide to add it like this, > > with ops? > > > That was from my review comment. Originally, I thought we > could share more code. For example I thought > vhost_run_work_kthread_list from patch 2 in this thread and > kernel/vhost_task.c:vhost_task_fn could be merged. > Hi Mike I guess you mean function vhost_run_work_list and vhost_run_work_kthread_list? sure, I will try to merge these two functions in next version Thanks Cindy
