On Thu, 20 Mar 2025 08:12:23 +0100 Maximilian Immanuel Brandtner <maxbr@xxxxxxxxxxxxx> wrote: > > Another thing I noticed during looking at this. AFAICT Linux does not > > seem to handle endiannes here. And AFAIU the message is supposed to > > hold > > le16 that is little endian u16! Maximilian, is this in your opinion > > something we need to fix as well? Or am I just missing the > > conversion? > > > > Regards, > > Halil > > Thanks, I didn't notice that, as I only tested this feature on x86. I > double checked struct virtio_console_config as it also defines cols > before rows, but there the kernel follows the spec (including > endianness). > I'll send a patch v2 shortly. I can send a fix for the endiannes issue. It should be a separate patch anyway. Regards, Halil
