On Mon, Mar 03, 2025 at 08:08:04PM +0100, Christophe JAILLET wrote: > virtcrypto_clear_request() does the same as the code here, but uses > kfree_sensitive() for one of the free operation. > > So, better safe than sorry, use virtcrypto_clear_request() directly to > save a few lines of code and cleanly free the memory. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > I've no idea if this is needed or not, but it looks not consistent to me. > > If safe as-is, maybe the kfree_sensitive() in virtcrypto_clear_request() > should be removed instead. > --- > drivers/crypto/virtio/virtio_crypto_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
