On 9/20/2025 8:22 AM, Dmitry Baryshkov wrote:
On Fri, Sep 19, 2025 at 08:21:01PM -0700, Wesley Cheng wrote:
The Glymur USB subsystem contains a multiport controller, which utilizes
two QMP UNI PHYs. Add the proper compatible string for the Glymur SoC.
Signed-off-by: Wesley Cheng <wesley.cheng@xxxxxxxxxxxxxxxx>
---
.../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index a1b55168e050..772a727a5462 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -16,6 +16,7 @@ description:
properties:
compatible:
enum:
+ - qcom,glymur-qmp-usb3-uni-phy
- qcom,ipq5424-qmp-usb3-phy
- qcom,ipq6018-qmp-usb3-phy
- qcom,ipq8074-qmp-usb3-phy
@@ -62,6 +63,8 @@ properties:
vdda-pll-supply: true
+ refgen-supply: true
You've added it, but it's not referenced as required. Why is it so?
Hi Dmitry,
The refgen clock isn't always required on each and every platform unlike
the .9v and 1.2v rail/supply, which directly power the QMP PHY. It only
really depends on how the refclk/CXO network is built for that
particular chipset. The refgen ensures that we're properly voting for
the supply that is powering our CXO buffer.
+
"#clock-cells":
const: 0
@@ -139,6 +142,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,glymur-qmp-usb3-uni-phy
- qcom,sdm845-qmp-usb3-uni-phy
then:
properties:
@@ -147,7 +151,7 @@ allOf:
clock-names:
items:
- const: aux
- - const: cfg_ahb
+ - enum: [cfg_ahb, clkref]
Why is it being placed here? Please comment in the commit message.
Main reason if to avoid having to define another IF/THEN block, but I
can do that as well if using enum here is not preferred.
Thanks
Wesley Cheng
- const: ref
- const: com_aux
- const: pipe
@@ -157,6 +161,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,glymur-qmp-usb3-uni-phy
- qcom,sa8775p-qmp-usb3-uni-phy
- qcom,sc8180x-qmp-usb3-uni-phy
- qcom,sc8280xp-qmp-usb3-uni-phy
--
linux-phy mailing list
linux-phy@xxxxxxxxxxxxxxxxxxx
https://lists.infradead.org/mailman/listinfo/linux-phy
