On Thu, Aug 21, 2025 at 11:33 AM Janne Grunau <j@xxxxxxxxxx> wrote: > > On Thu, Aug 21, 2025 at 03:38:55PM +0000, Sven Peter wrote: > > Apple's Type-C PHY (ATCPHY) is a PHY for USB 2.0, USB 3.x, > > USB4/Thunderbolt, and DisplayPort connectivity found in Apple Silicon > > SoCs. > > > > The PHY handles muxing between these different protocols and also provides > > the reset controller for the attached dwc3 USB controller. > > > > Signed-off-by: Sven Peter <sven@xxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/apple,atcphy.yaml | 210 +++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 211 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/apple,atcphy.yaml b/Documentation/devicetree/bindings/phy/apple,atcphy.yaml > > new file mode 100644 > > index 0000000000000000000000000000000000000000..eb14010557c94f313b54b528e2d4039fe540062a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/apple,atcphy.yaml > > @@ -0,0 +1,210 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/apple,atcphy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Apple Type-C PHY (ATCPHY) > > + > > +maintainers: > > + - Sven Peter <sven@xxxxxxxxxx> > > + > > +description: > > + The Apple Type-C PHY (ATCPHY) is a PHY for USB 2.0, USB 3.x, > > + USB4/Thunderbolt, and DisplayPort connectivity found in Apple Silicon SoCs. > > + > > + The PHY handles muxing between these different protocols and also provides the > > + reset controller for the attached dwc3 USB controller. > > + > > + The PHY is designed for USB4 operation and does not handle individual > > + differential pairs as distinct DisplayPort lanes. Any reference to lane in > > + this binding hence refers to two differential pairs (RX and TX) as used in USB > > + terminology. > > + > > +properties: > > + compatible: > > + enum: > > + - apple,t6000-atcphy > > + - apple,t6000-atcphy-dp-only # PHY hardwired to DP-to-HDMI converter on M2 Pro MacBook > > The comment is misleading, "t6000-atcphy-dp-only" would be for M1 > Pro/Max Macbooks. M2 Pro/Max Macbooks use the same design so the > corresponding "apple,t6020-atcphy-dp-only" compatible is missing. > I'm not sure this is the correct design though as the HW block is > identical to "apple,t6000-atcphy". > I think it might be better to have either the DRM KMS driver or a > custom DP->HDMI drm_bridge switch the mode to DP-only. > Or atcphy could initialize itself to DP-only based on the available > ports. Doesn't sound like this should be a different compatible. There's a 'phy-mode' property or you can define the mode in the 'phys' cells for the DP controller. Rob
