On Thu, Aug 21, 2025 at 11:28:23PM +0200, Jihed Chaibi wrote: > Convert the legacy TXT binding for the TWL4030 USB module > to the modern YAML DT schema format. This adds formal validation > and improves documentation using a conditional schema. > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@xxxxxxxxx> > > --- > Changes in v5: > > - Split combined twlxxxx-usb binding into a dedicated file for > twl4030-usb per maintainer feedback. > - Used more accurate header for interrupt macros. > - Improved formatting in the examples. > > Changes in v4: > - This patch is split from larger series per maintainer feedback. > - v3 link: > https://lore.kernel.org/all/20250816021523.167049-1-jihed.chaibi.dev@xxxxxxxxx/ > - Removed i2c node as it wasn't required by the old binding file. > - Updated node names to 'usb' and 'usb-phy' in the examples to follow > generic naming conventions per the Device Tree specification. > - Replaced raw interrupt values with standard defines for clarity. > - Improved formatting in the examples for clarity and consistency. > > Changes in v3: > - No changes. > > Changes in v2: > - Added '#phy-cells' property to support PHY framework integration. > --- > .../bindings/usb/ti,twl4030-usb.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,twl4030-usb.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ti,twl4030-usb.yaml b/Documentation/devicetree/bindings/usb/ti,twl4030-usb.yaml > new file mode 100644 > index 000000000..a2d3c5f60 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,twl4030-usb.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ti,twl4030-usb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TWL4030 USB PHY and Comparator > + > +maintainers: > + - Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> > + > +description: > + Bindings for the USB PHY and comparator module found within the > + TWL4030 family of companion chips. If a sibling node is compatible with > + "ti,twl4030-bci", the driver for that node will query this device for > + USB power status. > + > +properties: > + compatible: > + const: ti,twl4030-usb > + > + interrupts: > + description: > + Interrupt numbers to the CPU for ID and VBUS events. The first interrupt Confusing. So first is CPU? > + is the OTG interrupt for both ID and VBUS events. The second interrupt But furst is OTG? > + is optional. After splitting the binding this should be rewritten. Drop description, no need for free form text. minItems: 1 items: - description: OTG for ... - description: foo bar and do not say it is optional because it is obvious from schema Missing also removal of this device from the TXT binding. Best regards, Krzysztof
