The aim of this patch set is to introduce tracing for PORTCS writes and implement a Port Register Set struct. Introduces a new struct for the Host Controller USB Port Register Set. The current implementation accesses these registers through a single '__le32' pointer, which, in conjunction with a macro, navigates to the specific register using (base address + offset). Currently, how its accessed | Register Name -------------------------------------------------------------------------- port->addr | Port Status and Control port->addr + PORTPMSC | Port Power Management Status and Control port->addr + PORTLI | Port Link Info port->addr + PORTHLPMC | Port Hardware LPM Control After, how its accessed | Register Name -------------------------------------------------------------------------- port->port_reg->portsc | Port Status and Control port->port_reg->portpmsc | Port Power Management Status and Control port->port_reg->portli | Port Link Info port->port_reg->porthlmpc | Port Hardware LPM Control These changes make it easier for future modification and their review. Note: I have chosen to split the struct changes across three separate commits due to the substantial number of modified lines. Personally, I find that minor typos are more likely to occur when dealing with larger patches. However, I am open to consolidating these patches into a single commit after review. Niklas Neronin (7): usb: xhci: correct indentation for PORTCS tracing function usb: xhci: align PORTCS trace with one-based port numbering usb: xhci: improve xhci_decode_portsc() usb: xhci: add tracing for PORTCS register writes usb: xhci: add USB Port Register Set struct usb: xhci: implement USB Port Register Set struct usb: xhci: rename Port Register Set pointer in struct 'xhci_port' drivers/usb/host/xhci-debugfs.c | 6 +- drivers/usb/host/xhci-hub.c | 115 ++++++++++++++++---------------- drivers/usb/host/xhci-mem.c | 3 +- drivers/usb/host/xhci-pci.c | 4 +- drivers/usb/host/xhci-ring.c | 2 +- drivers/usb/host/xhci-tegra.c | 12 ++-- drivers/usb/host/xhci-trace.h | 39 ++++++----- drivers/usb/host/xhci.c | 41 +++++++----- drivers/usb/host/xhci.h | 94 +++++++++++++------------- 9 files changed, 161 insertions(+), 155 deletions(-) -- 2.50.1