On Sat, Aug 30, 2025 at 01:04:20PM +0200, Thorsten Blum wrote:
> Use min() to improve ucsi_stm32g0_fw_cb() and avoid calculating
> 'end - data' twice.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/ucsi/ucsi_stm32g0.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_stm32g0.c b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> index 57ef7d83a412..838ac0185082 100644
> --- a/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> +++ b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> @@ -10,6 +10,7 @@
> #include <linux/firmware.h>
> #include <linux/i2c.h>
> #include <linux/interrupt.h>
> +#include <linux/minmax.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/unaligned.h>
> @@ -523,11 +524,7 @@ static void ucsi_stm32g0_fw_cb(const struct firmware *fw, void *context)
> data = fw->data;
> end = fw->data + fw->size;
> while (data < end) {
> - if ((end - data) < STM32G0_I2C_BL_SZ)
> - size = end - data;
> - else
> - size = STM32G0_I2C_BL_SZ;
> -
> + size = min(end - data, STM32G0_I2C_BL_SZ);
> ret = ucsi_stm32g0_bl_write(g0->ucsi, addr, data, size);
> if (ret) {
> dev_err(g0->dev, "Write failed %d\n", ret);
> --
> 2.50.1
--
heikki
