On Fri, Sep 5, 2025 at 12:34 PM Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > On Mon, Aug 25, 2025 at 02:57:50PM +0000, Andrei Kuchynski wrote: > > This patch introduces a priority sysfs attribute to the USB Type-C > > alternate mode port interface. This new attribute allows user-space to > > configure the numeric priority of alternate modes managing their preferred > > order of operation. > > > > Signed-off-by: Andrei Kuchynski <akuchynski@xxxxxxxxxxxx> > > --- > > Documentation/ABI/testing/sysfs-class-typec | 11 +++++++ > > drivers/usb/typec/class.c | 32 ++++++++++++++++++++- > > Maybe patch 4/5 could be squashed into this patch, and I'm wondering > would it make sense to just keep the typec_mode_set_priority() in this > file (drivers/usb/typec/class.c). > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > -- > heikki You're right, mode_selection.c is quite empty now. However, in the next series, it will be the only user of the priority variable. So I'd prefer to keep it there, if you don’t mind. I think putting it in class.c would create a mess. Thank you for the review! Andrei
