On Wed, Sep 10, 2025 at 3:36 PM Hans de Goede <hansg@xxxxxxxxxx> wrote: > > Hi Greg, > > On 10-Sep-25 3:25 PM, Greg Kroah-Hartman wrote: > > On Sun, Sep 07, 2025 at 07:50:53PM +0200, Hans de Goede wrote: > >> Hi All, > >> > >> Here is v2 of the patch series to add support for the Intel USBIO USB > >> IO-expander used by the MIPI cameras on various new (Meteor Lake and later) > >> Intel laptops. > >> > >> Changes in v2: > >> - Split usbio-bridge mutex into ctrl_mutex and bulk_mutex > >> - Drop SPI support since this is not used on devices in the field > >> - Rework disconnect handling to be more robust > >> - Several different revisions need special casing add a quirks mechanism > >> for this > >> - Stop using stdint.h (uintX_t) types > >> - Use __le16, __le32 type + cpu_to_le16() and friends for on wire words > >> - Properly check auxiliary_device_add() return value > >> - Add a mutex to the GPIO driver to protect usbio_gpio_update_config() > >> calls, which read-modify-write banks[x].config, racing with each other > >> - Adjust usbio_gpio_get() to have an int return value and propagate the > >> usbio_control_msg() return value > >> - Various (small) style fixes from Sakari's review of all 3 patches > >> > >> The first patch adds an USB bridge driver which registers auxbus children > >> for the GPIO and I2C functions of the USBIO chip. > >> > >> The second and third patch add a GPIO resp. an I2C driver for the > >> auxbus children using the IO functions exported by the USB bridge driver. > >> > >> The second and third patch depend on the IO functions exported by > >> the first patch. So to merge this we will need either an immutable tag on > >> the USB tree, or all 3 patches can be merged through the USB tree with > >> acks from the GPIO and I2C subsystem maintainers. > > > > Either is fine with me, patch 1 looks good enough for me to queue it up > > now. > > That is good news. > > > Let me know what you want me to do. > > I've done a v3 of just the GPIO patch since Bart had some review-comments > there. Bart still had 2 more small remarks on the v3 GPIO patch. So I'm > about to send out a v4 series (with just changes to the GPIO driver > compared to this v2). > > I hope Bart will be happy with v4, so then Bart can let you know if > he prefers an immutable tag, or wants you to merge the GPIO driver > into usb-next. > Yes, an immutable branch with patch 1 would be the best approach. Bart > Once it is clear how to proceed with the GPIO driver I suggest that > we get both of them merged and then wait for feedback on the I2C driver. > > Regards, > > Hans > >
