Hi Stephen, On Tue, Apr 29, 2025 at 7:47 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Pin-yen Lin (2025-04-22 01:28:27) > > diff --git a/Documentation/devicetree/bindings/usb/usb-hub.yaml b/Documentation/devicetree/bindings/usb/usb-hub.yaml > > new file mode 100644 > > index 00000000000000..5238ab10576308 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/usb-hub.yaml > > @@ -0,0 +1,84 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/usb-hub.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Generic USB Hub > > + > > +maintainers: > > + - Pin-yen Lin <treapking@xxxxxxxxxxxx> > > + > > +allOf: > > + - $ref: usb-device.yaml# > > + > > +properties: > > + '#address-cells': > > + const: 1 > > + > > + peer-hub: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + phandle to the peer hub on the controller. > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + description: > > + The downstream facing USB ports > > + > > + patternProperties: > > + "^port@[1-9a-f][0-9a-f]*$": > > + $ref: /schemas/graph.yaml#/properties/port > > + > > +patternProperties: > > + '^.*@[1-9a-f][0-9a-f]*$': > > + description: The hard wired USB devices > > + type: object > > + $ref: /schemas/usb/usb-device.yaml > > + additionalProperties: true > > + > > +required: > > + - compatible > > + - reg > > Can 'reg' be dropped because usb-device.yaml requires it? As I replied in patch 3/4, I see other schemas still re-define them as required. I can send a new version to drop this if no one comes out and say this is actually a convention. Regards, Pin-yen
