On 4/16/25 4:45 PM, Niklas Neronin wrote: > Move the assignment of the doorbell array pointer from xhci_mem_init() > to xhci_init(). The assignment now utilizes the newly introduced > xhci_set_doorbell_ptr() function. > > Doorbell Array Offset mask (DBOFF_MASK) is updated to directly specify its > bit range as 31:2, rather than using inverted reserved bits 1:0. > This change simplifies the mask representation, making it more intuitive > and easier to understand. > > Remove the "// " prefix from trace messages, as it is unnecessary and > distracting. > > Signed-off-by: Niklas Neronin <niklas.neronin@xxxxxxxxxxxxxxx> > --- > drivers/usb/host/xhci-caps.h | 4 ++-- > drivers/usb/host/xhci-mem.c | 8 -------- > drivers/usb/host/xhci.c | 13 +++++++++++++ > 3 files changed, 15 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/host/xhci-caps.h b/drivers/usb/host/xhci-caps.h > index f6b9a00a0ab9..4b8ff4815644 100644 > --- a/drivers/usb/host/xhci-caps.h > +++ b/drivers/usb/host/xhci-caps.h > @@ -62,8 +62,8 @@ > > #define CTX_SIZE(_hcc) (HCC_64BYTE_CONTEXT(_hcc) ? 64 : 32) > > -/* db_off bitmask - bits 0:1 reserved */ > -#define DBOFF_MASK (~0x3) > +/* db_off bitmask - bits 31:2 Doorbell Array Offset */ > +#define DBOFF_MASK (0xfffffffc) I don't think parens here are really needed... [...] MBR, Sergey
