On Wed, 16 Jul 2025 at 02:47, NeilBrown <neil@xxxxxxxxxx> wrote:
> +int ovl_cleanup_unlocked(struct ovl_fs *ofs, struct dentry *workdir,
> + struct dentry *wdentry)
> +{
> + int err;
> +
> + err = ovl_parent_lock(workdir, wdentry);
> + if (err)
> + return err;
We get a pr_err() if the cleanup failed for some reason. But in this
case it's just an -EINVAL return, which most callers of ovl_cleanup()
ignore.
I guess pr_err_ratelimited() in this case wouldn't hurt, since it
either indicates a bug in the code, which we want to know about, or
mischief, in which case the one making the mischief shouldn't be
surprised.
Thanks,
Miklos
