Re: [PATCH] fuse: return -EOPNOTSUPP from ->fileattr_[gs]et() instead of -ENOTTY

[Miklos Szeredi <miklos@xxxxxxxxxx>]

On Tue, 1 Jul 2025 at 16:29, Amir Goldstein <amir73il@xxxxxxxxx> wrote:

> index 6f0e15f86c21..92754749f316 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -722,7 +722,7 @@ int ovl_real_fileattr_get(const struct path *realpath, struct fileattr *fa)
>
>         err = vfs_fileattr_get(realpath->dentry, fa);
>         if (err == -ENOIOCTLCMD)
> -               err = -ENOTTY;
> +               err = -EOPNOTSUPP;

This doesn't make sense, the Andrey's 4/6 patch made vfs_fileattr_get
return EOPNOTSUPP instead of ENOIOCTLCMD.  So why is it being checked
here?

Thanks,
Miklos