Re: [PATCH v3] ovl: support layers on case-folding capable filesystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2 Jun 2025 at 19:17, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> Case folding is often applied to subtrees and not on an entire
> filesystem.
>
> Disallowing layers from filesystems that support case folding is over
> limiting.
>
> Replace the rule that case-folding capable are not allowed as layers
> with a rule that case folded directories are not allowed in a merged
> directory stack.
>
> Should case folding be enabled on an underlying directory while
> overlayfs is mounted the outcome is generally undefined.
>
> Specifically in ovl_lookup(), we check the base underlying directory
> and fail with -ESTALE and write a warning to kmsg if an underlying
> directory case folding is enabled.
>
> Suggested-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>
> Link: https://lore.kernel.org/linux-fsdevel/20250520051600.1903319-1-kent.overstreet@xxxxxxxxx/
> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>

Acked-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>

Looks good.  Thanks for taking care of this.

The only think I don't like is the pr_warn_ratelimited().  I totally
understand why you did it, and I'd love to have generic infrastructure
for returning extra error info without spamming dmesg.   Oh well.

Thanks,
Miklos




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux