On Thu, Jun 5, 2025 at 7:24 PM Zorro Lang <zlang@xxxxxxxxxx> wrote:
>
> On Tue, Jun 03, 2025 at 12:07:44PM +0200, Amir Goldstein wrote:
> > commit f5661920 ("generic: add missed _require_idmapped_mounts check")
> > wrongly adds _require_idmapped_mounts to tests that do not require
> > idmapped mounts support.
> >
> > The added _require_idmapped_mounts in test generic/633 goes against
> > commit d8dee122 ("idmapped-mounts: always run generic vfs tests")
> > that intentionally removed this requirement from the generic tests.
> >
> > The added _require_idmapped_mounts in tests generic/69{6,7} causes
> > those tests not to run with overlayfs, which does not support idmapped
> > mounts. However, those tests are regression tests to kernel commit
> > 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers")
> > which is documented as also solving a correction issue with overlayfs,
> > so removing this test converage is very much undesired.
> >
> > Remove the incorrectly added _require_idmapped_mounts checks.
> > Also fix the log in _require_idmapped_mounts to say that
> > "idmapped mounts not support by $FSTYP", which is what the helper
> > checks instead of "vfstests not support by $FSTYP" which is incorrect.
> >
> > Cc: Yang Xu <xuyang2018.jy@xxxxxxxxxxx>
> > Cc: Anthony Iliopoulos <ailiop@xxxxxxxx>
> > Cc: David Disseldorp <ddiss@xxxxxxx>
> > Fixes: commit f5661920 ("generic: add missed _require_idmapped_mounts check")
> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > ---
>
> Is this one changed anything from this ?
> https://lore.kernel.org/fstests/20250526175437.1528310-1-amir73il@xxxxxxxxx/
There is no change. I just forgot to add the RVB.
>
> Due to above link has been reviewed by Christian Brauner, do you want to
> add his RVB to this version?
>
Yes please.
Thanks,
Amir.
