On Thu, Feb 20, 2025 at 12:48 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Thu, 20 Feb 2025 at 12:39, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: > > > > Miklos Szeredi <miklos@xxxxxxxxxx> writes: > > > > > On Thu, 20 Feb 2025 at 10:54, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: > > >> > > >> Miklos Szeredi <miklos@xxxxxxxxxx> writes: > > >> > > >> > On Tue, 11 Feb 2025 at 16:52, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > >> >> The short version - for lazy data lookup we store the lowerdata > > >> >> redirect absolute path in the ovl entry stack, but we do not store > > >> >> the verity digest, we just store OVL_HAS_DIGEST inode flag if there > > >> >> is a digest in metacopy xattr. > > >> >> > > >> >> If we store the digest from lookup time in ovl entry stack, your changes > > >> >> may be easier. > > >> > > > >> > Sorry, I can't wrap my head around this issue. Cc-ing Giuseppe. > > > > > > Giuseppe, can you describe what should happen when verity is enabled > > > and a file on a composefs setup is copied up? > > > > we don't care much about this case since the composefs metadata is in > > the EROFS file system. Once copied up it is fine to discard this > > information. Adding Alex to the discussion as he might have a different > > opinion/use case in mind. > > Okay. > > Amir, do I understand correctly that your worry is that after copy-up > verity digest is still being used? If that's the case, we just need > to make sure that OVL_HAS_DIGEST is cleared on copy-up? > > Or am I still misunderstanding this completely? Sorry, I have somehow missed this email. TBH, I am not sure what is expected to happen in the use case in question on copy up - that is if a full copy up on any metadata change is acceptable. Technically, we could allow a metacopy upper as long as we take the md5digest from the middle layer but that complicates things and I am not sure if we need to care - can't wrap my head around this case either. Thanks, Amir.
