I'm using as-packaged in Ubuntu 24.04. But reading tgtd.c I was struck by some of the logic. while I get the purpose of sd_notify(), technically and from an ordering perspective, shouldn't that be only when '-exec' is called later on and targets are defined? Or are we relying on one of the 'ExecPost' actions to blow up and indicate the service is failed? But isn't that way too late? Downstream dependencies have already fired. I'm assuming '—forground' is chosen in a systemD context is so that logs will be picked up by systemD. So why not #ifdef USE_SYSTEMD to also emit the PID to stdout, if pidfile is undefined? Also the choice of LOG_WARNING in log_init() is highly unusual. It should be LOG_INFO if perhaps LOG_NOTICE. A routine message is never emitted at WARN.
