On Thu, May 15, 2025 at 01:02:20PM -0700, Bart Van Assche wrote: > On 5/10/25 5:41 PM, Eric Biggers wrote: > > Instead of calling __skb_checksum() with a skb_checksum_ops struct that > > does CRC32C, just call the new function skb_crc32c(). This is faster > > and simpler. > Bernard, since you are the owner and author of the siw driver, please help > with reviewing this patch. > > Eric, do you already have a test case for the siw driver? If not, > multiple tests in the blktests framework use this driver intensively, > including the SRP tests that I wrote myself. See also > https://github.com/osandov/blktests. No. I'll try that out when I have a chance. If the developers/maintainers of the driver could help test it, that would be a lot easier though. I've been cleaning up the CRC calls across the whole kernel, and it gets time-consuming when individual subsystems insist on me running their custom test suite(s) and providing subsystem-specific benchmarks. - Eric
