> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 19 August 2025 12:04 > To: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Shradha Todi <shradha.t@xxxxxxxxxxx>; Krzysztof > Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx; > mani@xxxxxxxxxx; lpieralisi@xxxxxxxxxx; kwilczynski@xxxxxxxxxx; robh@xxxxxxxxxx; > bhelgaas@xxxxxxxxxx; jingoohan1@xxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > alim.akhtar@xxxxxxxxxxx; vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; arnd@xxxxxxxx; > m.szyprowski@xxxxxxxxxxx; jh80.chung@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx > Subject: Re: [PATCH v3 11/12] PCI: exynos: Add support for Tesla FSD SoC > > On 18/08/2025 20:25, Bjorn Helgaas wrote: > > [+to Krzysztof] > > > > On Mon, Aug 18, 2025 at 03:00:00PM +0530, Shradha Todi wrote: > >>> On Mon, Aug 11, 2025 at 09:16:37PM +0530, Shradha Todi wrote: > >>>> Add host and endpoint controller driver support for FSD SoC. > > > >>> It's kind of unfortunate that the driver uses "ep" everywhere for > >>> struct exynos_pcie pointers. It's going to be confusing because "ep" > >>> is also commonly used for endpoint-related things, e.g., struct > >>> dw_pcie_ep pointers. Maybe it's not worth changing; I dunno. > >> > >> I did try to rename the structure and the pointers > >> (https://lore.kernel.org/all/20230214121333.1837-9-shradha.t@xxxxxxxxxxx/) > >> But the intention was different back then and so the idea was rejected. > >> I could add a patch to only rename the pointers to something less > >> confusing like "exy_pci" > > > > The patch you mention did several renames: > > > > s/to_exynos_pcie/to_samsung_pcie/ > > s/struct exynos_pcie/struct samsung_pcie/ > > s/struct exynos_pcie *ep/struct samsung_pcie *sp/ > > > > I'm only concerned about the confusion of "ep" being used both for > > "struct exynos_pcie *" and for "struct dw_pcie_ep *". > > > > It would still be sort of an annoying patch to do something like this: > > > > s/struct exynos_pcie *ep/struct exynos_pcie *pcie/ > > > > But 'git grep "struct .*_pcie \*.*=" drivers/pci/controller/' says > > using "pcie" in this way is quite common, so maybe it would be worth > > doing. > > > > What do you think, Krzysztof? > > I think you want other Krzysztof, but nevertheless, the reasoning there > "Changing it to samsung_pcie for making it > generic." > is wrong. The naming of these structures do not matter, they are not > less generic. This is rather churn, which will affect backporting for > ZERO readability increase. Why zero? Because calling all this "exynos" > is the same as calling all this "samsung". It just does not matter. > > However s/ep/pcie/ in variable name makes sense if that's more common. > I will add a patch in the series to do that. > > Best regards, > Krzysztof
