On 23/08/2025 04:39, Inbaraj E wrote: > Hi Krzysztof, > > Thanks for the review. > >> On 14/08/2025 16:09, Inbaraj E wrote: >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >>> + - iommus >>> + - port >> >> Also, you miss here supplies (as required). > > According to the HW design of FSD SoC, the control to manage CSIS power is given to > a separate CPU where custom firmware runs. Therefore. The Linux side does not control > the CSIS power supplies directly and are hence not included in the device tree. Usually this still means you vote for enabling these resources, at least for other vendors it is like that. Unless you want to say these are essentially always on and CANNOT be disabled ever. Best regards, Krzysztof