On Tue, Aug 12, 2025 at 09:39:45PM +0800, Icenowy Zheng wrote: > I was doing a patch to add divider setting support to clk-th1520-ap > driver and sent patch now, should I remove round_rate from the next > revision and just keep determine_rate? Is it safe to do this even if > this patchset is not merged? Yes, you only need to implement the determine_rate() clk op. Please remove any references to the round_rate() clk op from your driver. If you implement both, then only the determine_rate() clk op is actually used by the clk core. > In addition, will the clk_round_rate() API exported to other subsystems > be affected? No, that will stay as is, and with the same name. The underlying implementation in the clk core uses the determine_rate() clk op. Brian