On Mon, 2025-08-11 at 11:18 -0400, Brian Masney via B4 Relay wrote:
> From: Brian Masney <bmasney@xxxxxxxxxx>
>
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
>
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> ---
> drivers/clk/clk-ep93xx.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c
> index 4bd8d6ecf6a2bde26287e4e949b062a5660139e6..b081ef920e250dd99134af6845c443ee11266da8 100644
> --- a/drivers/clk/clk-ep93xx.c
> +++ b/drivers/clk/clk-ep93xx.c
> @@ -389,23 +389,25 @@ static unsigned long ep93xx_div_recalc_rate(struct clk_hw *hw,
> return DIV_ROUND_CLOSEST(parent_rate, clk->div[index]);
> }
>
> -static long ep93xx_div_round_rate(struct clk_hw *hw, unsigned long rate,
> - unsigned long *parent_rate)
> +static int ep93xx_div_determine_rate(struct clk_hw *hw,
> + struct clk_rate_request *req)
> {
> struct ep93xx_clk *clk = ep93xx_clk_from(hw);
> unsigned long best = 0, now;
> unsigned int i;
>
> for (i = 0; i < clk->num_div; i++) {
> - if ((rate * clk->div[i]) == *parent_rate)
> - return rate;
> + if (req->rate * clk->div[i] == req->best_parent_rate)
> + return 0;
>
> - now = DIV_ROUND_CLOSEST(*parent_rate, clk->div[i]);
> - if (!best || is_best(rate, now, best))
> + now = DIV_ROUND_CLOSEST(req->best_parent_rate, clk->div[i]);
> + if (!best || is_best(req->rate, now, best))
> best = now;
> }
>
> - return best;
> + req->rate = best;
> +
> + return 0;
> }
>
> static int ep93xx_div_set_rate(struct clk_hw *hw, unsigned long rate,
> @@ -437,7 +439,7 @@ static const struct clk_ops ep93xx_div_ops = {
> .disable = ep93xx_clk_disable,
> .is_enabled = ep93xx_clk_is_enabled,
> .recalc_rate = ep93xx_div_recalc_rate,
> - .round_rate = ep93xx_div_round_rate,
> + .determine_rate = ep93xx_div_determine_rate,
> .set_rate = ep93xx_div_set_rate,
> };
--
Alexander Sverdlin.
