Hi Rob, > -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: 07 August 2025 05:13 AM > To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx> > Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; andre.draszik@xxxxxxxxxx; > peter.griffin@xxxxxxxxxx; kauschluss@xxxxxxxxxxx; > ivo.ivanov.ivanov1@xxxxxxxxx; igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux- > phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > samsung-soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx; > dev.tailor@xxxxxxxxxxx; faraz.ata@xxxxxxxxxxx; > muhammed.ali@xxxxxxxxxxx; selvarasu.g@xxxxxxxxxxx > Subject: Re: [PATCH v5 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo ssphy > > On Tue, Aug 05, 2025 at 05:22:15PM +0530, Pritam Manohar Sutar wrote: > > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > > compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > > "phy" and "ref". The required supplies for USB3.1 are named as > > vdd075_usb30(0.75v), vdd18_usb30(1.8v). > > > > Add schemas for combo ssphy found on this SoC. > > > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx> > > --- > > .../bindings/phy/samsung,usb3-drd-phy.yaml | 19 > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > index 4a84b5405cd2..7a71cff10fb5 100644 > > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd- > phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd- > phy.yaml > > @@ -34,6 +34,7 @@ properties: > > - samsung,exynos7870-usbdrd-phy > > - samsung,exynos850-usbdrd-phy > > - samsung,exynos990-usbdrd-phy > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > - samsung,exynosautov920-usbdrd-combo-hsphy > > - samsung,exynosautov920-usbdrd-phy > > > > @@ -118,6 +119,12 @@ properties: > > vdd18-usb20-supply: > > description: 1.8V power supply for the USB 2.0 phy. > > > > + dvdd075-usb30-supply: > > + description: 0.75V power supply for the USB 3.0 phy. > > + > > + vdd18-usb30-supply: > > + description: 1.8V power supply for the USB 3.0 phy. > > + > > required: > > - compatible > > - clocks > > @@ -227,6 +234,7 @@ allOf: > > - samsung,exynos7870-usbdrd-phy > > - samsung,exynos850-usbdrd-phy > > - samsung,exynos990-usbdrd-phy > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > - samsung,exynosautov920-usbdrd-combo-hsphy > > - samsung,exynosautov920-usbdrd-phy > > then: > > @@ -258,6 +266,17 @@ allOf: > > - vdd18-usb20-supply > > - vdd33-usb20-supply > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > + then: > > + required: > > + - dvdd075-usb30-supply > > + - vdd18-usb30-supply > > Similar issue here. Will the suggested lines of the code in next version of the patch-set. Snippet will look as below. + - if: + properties: + compatible: + contains: + enum: + - samsung,exynosautov920-usb31drd-combo-ssphy + then: + required: + - dvdd075-usb30-supply + - vdd18-usb30-supply + + else: + properties: + dvdd075-usb30-supply: false + vdd18-usb30-supply: false Thank you. Regards, Pritam
