On 07/08/2025 12:59, Krzysztof Kozlowski wrote:
> On 07/08/2025 05:24, Aakarsh Jain wrote:
>> Modify the MFC device tree node to use a SoC-specific
>> compatible string instead of a generic one.
>
> Why?
>
>>
>> Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/samsung/exynos4.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> index ed47d0ce04e1..a2f15fbe98cb 100644
>> --- a/arch/arm/boot/dts/samsung/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> @@ -435,7 +435,7 @@ i2s2: i2s@13970000 {
>> };
>>
>> mfc: codec@13400000 {
>> - compatible = "samsung,mfc-v5";
>> + compatible = "samsung,exynos4-mfc";
>
> There are so many things wrong here...
>
> 1. This breaks all users
> 2. Not a correct compatible - there is no exynos4 (see writing bindings)
> 3. Commit msg does not explain why breaking users is reasonable
Ah and 4: there is no such compatible, so this fails tests.
Best regards,
Krzysztof
