Hi Jacopo, Thanks for your effort tidying things up! On 2025-08-02 11:22:39 +0200, Jacopo Mondi wrote: > The R-Car VIN driver sets file->private_data to the driver-specific > structure, but the following call to v4l2_fh_open() overwrites it > with a pointer to the just allocated v4l2_fh. > > Remove the mis-leading assignment in the driver. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > index 62eddf3a35fc91434cb2e584a01819380a7a6dd8..079dbaf016c25139e2ac82be63d8fce0d11fd208 100644 > --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > @@ -588,8 +588,6 @@ static int rvin_open(struct file *file) > if (ret) > goto err_pm; > > - file->private_data = vin; > - > ret = v4l2_fh_open(file); > if (ret) > goto err_unlock; > > -- > 2.49.0 > -- Kind Regards, Niklas Söderlund
