Re: [PATCH v3 04/14] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maxime,

On 2025/7/29 15:30, Maxime Ripard wrote:
Hi,

On Thu, Jul 24, 2025 at 04:02:54PM +0800, Damon Ding wrote:
In order to move the parnel/bridge parsing and attachmenet to the
Analogix side, add component struct drm_bridge *bridge to platform
data struct analogix_dp_plat_data.

The movemenet makes sense because the panel/bridge should logically
be positioned behind the Analogix bridge in the display pipeline.

Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx>
---
  include/drm/bridge/analogix_dp.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h
index cf17646c1310..15cb6b706e9f 100644
--- a/include/drm/bridge/analogix_dp.h
+++ b/include/drm/bridge/analogix_dp.h
@@ -27,6 +27,7 @@ static inline bool is_rockchip(enum analogix_dp_devtype type)
  struct analogix_dp_plat_data {
  	enum analogix_dp_devtype dev_type;
  	struct drm_panel *panel;
+	struct drm_bridge *bridge;
  	struct drm_encoder *encoder;
  	struct drm_connector *connector;
  	bool skip_connector;

So it's not the analogix_dp bridge, but the bridge after that if any?

You should probably change it to next_bridge to avoid any confusion.


Yes, &analogix_dp_plat_data.bridge is intended to be the next bridge after analogix_dp bridge.

I will rename it to &analogix_dp_plat_data.next_bridge as suggested and update it in the next version.

Best regards,
Damon





[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux