Hi Sangwook > -----Original Message----- > From: Sangwook Shin <sw617.shin@xxxxxxxxxxx> > Sent: Monday, July 14, 2025 11:25 AM > To: krzk@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; wim@xxxxxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Sangwook Shin <sw617.shin@xxxxxxxxxxx> > Subject: [PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded > values with macro definitions > > Modify the code to utilize macro-defined values instead of hardcoded values. > The value 0x100 in the s3c2410wdt_set_heartbeat function represents > S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its > meaning difficult to understand and reducing code readability. > > Signed-off-by: Sangwook Shin <sw617.shin@xxxxxxxxxxx> > --- Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
