On Sat, 2025-07-12 at 21:26 +0200, Linus Walleij wrote: > Hi Hakyeong, > > thanks for your patch! > > On Thu, Jul 10, 2025 at 2:20 AM <ksk4725@xxxxxxxxxx> wrote: > > > Add basic support for the Axis ARTPEC-8 SoC. > > This SoC contains four Cortex-A53 CPUs and other several IPs. > > > > Patches 1 to 10 provide the support for the clock controller, > > which is similar to other Samsung SoCs. > > > > The remaining patches provide pinctrl support and > > initial device tree support. > > > > Hakyeong Kim (9): > > dt-bindings: clock: Add ARTPEC-8 CMU bindings > > clk: samsung: Add clock PLL support for ARTPEC-8 SoC > > clk: samsung: artpec-8: Add initial clock support > > clk: samsung: artpec-8: Add clock support for CMU_CMU block > > clk: samsung: artpec-8: Add clock support for CMU_BUS block > > clk: samsung: artpec-8: Add clock support for CMU_CORE block > > clk: samsung: artpec-8: Add clock support for CMU_CPUCL block > > clk: samsung: artpec-8: Add clock support for CMU_FSYS block > > clk: samsung: artpec-8: Add clock support for CMU_PERI block > > Out of the 9 patches there are 7 patches related to "CMU" without > any explanation or even expansion of this acronym. > > Camera Management Unit? I think I'm not supposed to > guess. Is is an Axis-custom piece of hardware? (Would make > sense.) > > Please expand this acronym and state clearly that (if this > is a correct assumption) that you are not supplying any > bindings and even less a driver for the "CMU" thing, just the > clocks. (That's fine the actual CMU can come later, but > it should be clear *what* it is.) Ok, I will add CMU abbreviation on cover-letter and respective patches. Thanks, Hakyeong Kim > > Yours, > Linus Walleij
