On Thu, Jul 10, 2025, at 18:53, Shivendra Pratap wrote:
> On 7/10/2025 9:00 PM, Arnd Bergmann wrote:
>> On Thu, Jul 10, 2025, at 11:15, Shivendra Pratap wrote:
>>
>>> + reset-types:
>>> + type: object
>>> + $ref: /schemas/power/reset/reboot-mode.yaml#
>>
>> The other users of the reboot-mode.yaml binding all call this
>> node 'reboot-mode' instead of 'reset-types', can you change that
>> here for consistency?
> nvmem-reboot-mode and syscon-reboot-mode use reboot-mode in the
> device tree node name.
> qcom-pon does not uses reboot-mode at its device tree node name, it
> uses pon.
> Kept it reset-types as this patch was already reviewed earlier and
> the name makes it closer to vendor-specific reset-type.
> Should we make it reboot-mode? Please suggest.
Yes, I would still change that. At least all the platform-independent
drivers are consistent that way.
Arnd
