Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 06 July 2025 03:12 PM > To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx> > Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; robh@xxxxxxxxxx; > krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > andre.draszik@xxxxxxxxxx; peter.griffin@xxxxxxxxxx; neil.armstrong@xxxxxxxxxx; > kauschluss@xxxxxxxxxxx; ivo.ivanov.ivanov1@xxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux- > phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx; > faraz.ata@xxxxxxxxxxx; muhammed.ali@xxxxxxxxxxx; > selvarasu.g@xxxxxxxxxxx > Subject: Re: [PATCH v4 3/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo HS phy > > On Tue, Jul 01, 2025 at 05:37:03PM +0530, Pritam Manohar Sutar wrote: > > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > > What is "this"? You add here HS PHY, so HS is 3.1? > "this" means "combo phy". Combo phy is combination of 2 types of the phys. 1. one supports only USB3.1 SSP+ and denoted as "samsung,exynosautov920-usb31drd-combo-ssphy" as in patch no 5 (combo SS phy) 2. another supports only USB2.0 HS and termed as "samsung,exynosautov920-usbdrd-combo-hsphy" as in this patch (combo HS phy) > If this is the same phy, why are you adding another compatible? As explained earlier (even in cover letter), there are 3 types of the phys in this SoC. 1. one is simmilar with exynos850 and termed as "samsung,exynosautov920-usbdrd-phy" as mentioned in patch no.1 2. two phys are in combo phys as explained above (patch no 3 [combo HS phy] and 5[combo SS phy]) NOTE: hs phy in combo phy in "NOT" same as phy (patch no. 1 which is similar with exynos850). These three phys (usbdrd-phy, combo-hsphy, combo-ssphy) are totally deferent "NOT" same, hence added 3 three compatible for three phys. > > Best regards, > Krzysztof
