On 09/07/2025 02:12, ew kim wrote: > Add a node for Abox generic. This driver, exynosautov920, connects to > the SoC and allows you to configure a sound card. DTS is not for drivers. NAK. > > Signed-off-by: ew kim <ew.kim@xxxxxxxxxxx> > --- > .../boot/dts/exynos/exynosautov920-audio.dtsi | 20 +++++++++++++++++++ > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 1 + > 2 files changed, 21 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi > new file mode 100644 > index 000000000000..4a1341ccdc2e > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi > @@ -0,0 +1,20 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2020 Samsung Electronics Co., Ltd. You need to clean up old downstream code. Read DTS coding style. > + * http://www.samsung.com/ > + * > + * EXYNOS - Audio Device Tree source > + */ > + > +/ { > + abox_generic: abox_generic@generic { > + compatible = "samsung,abox_generic"; > + samsung,num-of-pcm_playback = <32>; > + samsung,num-of-pcm_capture = <32>; > + samsung,num-of-i2s-dummy-backend = <5>; > + status = "disabled"; You just add dead code. This is very poor submission. Reach internally (or to experienced R&D in Poland) to guide you how to submit proper patches. Best regards, Krzysztof
