When adding the dedicated gs101_wkup_irq_chip struct to support the eint wakeup mask the .eint_con, eint_mask and .eint_pend fields were missed. The result is that irqs on gs101 for the buttons etc are broken. Reported-by: André Draszik <andre.draszik@xxxxxxxxxx> Fixes: 2642f55d44ce ("pinctrl: samsung: add support for gs101 wakeup mask programming") Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> --- Note: no Closes tag as issue was reported on private chat. Permission has been obtained for using the Reported-by tag. --- drivers/pinctrl/samsung/pinctrl-exynos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 5554768d465fe0d8bf6e423b2e835965cde5d8f5..81fe0b08a9af5682421e5a5533a6cb4c9561cd24 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -665,6 +665,9 @@ static const struct exynos_irq_chip gs101_wkup_irq_chip __initconst = { .irq_request_resources = exynos_irq_request_resources, .irq_release_resources = exynos_irq_release_resources, }, + .eint_con = EXYNOS7_WKUP_ECON_OFFSET, + .eint_mask = EXYNOS7_WKUP_EMASK_OFFSET, + .eint_pend = EXYNOS7_WKUP_EPEND_OFFSET, .eint_num_wakeup_reg = 3, .eint_wake_mask_reg = GS101_EINT_WAKEUP_MASK, .set_eint_wakeup_mask = gs101_pinctrl_set_eint_wakeup_mask, --- base-commit: 2aeda9592360c200085898a258c4754bfe879921 change-id: 20250702-fix-gs101-irqchip-8d12d369440c Best regards, -- Peter Griffin <peter.griffin@xxxxxxxxxx>