Hi Shao, On Fri, 20 Jun 2025 at 10:09, <shao.mingyin@xxxxxxxxxx> wrote: > From: Shao Mingyin <shao.mingyin@xxxxxxxxxx> > > Use str_enable_disable() and str_on_off() helper instead of open > coding the same. > > Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx> > Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> > --- > v3: > preserve the original patch format to avoid whitespace-damaged > drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++- > drivers/pmdomain/renesas/rcar-sysc.c | 3 ++- > drivers/pmdomain/rockchip/pm-domains.c | 3 ++- > drivers/pmdomain/samsung/exynos-pm-domains.c | 6 +++--- > drivers/pmdomain/starfive/jh71xx-pmu.c | 7 ++++--- > 5 files changed, 13 insertions(+), 9 deletions(-) > > diff --git a/drivers/pmdomain/renesas/rcar-gen4-sysc.c b/drivers/pmdomain/renesas/rcar-gen4-sysc.c > index e001b5c25bed..c8aa7538e95f 100644 > --- a/drivers/pmdomain/renesas/rcar-gen4-sysc.c > +++ b/drivers/pmdomain/renesas/rcar-gen4-sysc.c > @@ -18,6 +18,7 @@ > #include <linux/slab.h> > #include <linux/spinlock.h> > #include <linux/types.h> > +#include <linux/string_choices.h> Please insert new includes alphabetically, like in Krzysztof's original [1], for which I already provided my Rb-tag. [1] https://lore.kernel.org/all/CAMuHMdXJ57mATWW4AnBedn+D7TQ4PadkJ642daquFtAo=wZFrQ@xxxxxxxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
