On 28/06/2025 09:19, Kaustabh Chakraborty wrote: >>> diff --git >>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >>> index >>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 >>> 100644 >>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >>> @@ -172,6 +172,7 @@ allOf: >>> - samsung,exynos5250-pmu >>> - samsung,exynos5420-pmu >>> - samsung,exynos5433-pmu >>> + - samsung,exynos7870-pmu >> >> Don't you need to add this to 'compatible' and under 'select'? > > compatible: [1] > > samsung,exynos7-pmu is under select. 7870 has a fallback on 7. > Do you think samsung,exynos7-pmu should've been added in this patch > instead? > If this uses exynos7-pmu as fallback then it is fine. This should be in commit msg - that's the point of commit msg - explain the hardware and things not easily visible, instead of repeating what is visible in the diff. Best regards, Krzysztof
