On Wed, Apr 30, 2025 at 06:02:56PM +0530, Anand Moon wrote: > Hi All, Hi Anand, if the goal of the changes is to do cleanups, I recommend to rework how the code is organized. Instead of having the data->soc check all around the functions, write per platform functions and store them in struct of_device_id data field instead of the soc version. Basically get rid of exynos_map_dt_data by settings the different ops in a per platform structure. Then the initialization routine would be simpler to clean. > This patch series is a rework of my previous patch series [1], > where the code changes were not adequately justified. > > In this new series, I have improved the commit subject > and commit message to better explain the changes. > > v6: Add new patch to use devm_clk_get_enabled > and Fix few typo in subject as suggested by Daniel. > v5: Drop the guard mutex patch > v4: Tried to address Lukasz review comments. > > Tested on Odroid U3 amd XU4 SoC boards. > Build with clang with W=1 enable. > > [4] https://lore.kernel.org/all/20250410063754.5483-2-linux.amoon@xxxxxxxxx/ > [3] https://lore.kernel.org/all/20250310143450.8276-2-linux.amoon@xxxxxxxxx/ > [2] https://lore.kernel.org/all/20250216195850.5352-2-linux.amoon@xxxxxxxxx/ > [1] https://lore.kernel.org/all/20220515064126.1424-1-linux.amoon@xxxxxxxxx/ > [0] https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@xxxxxxxxxxxxxx/T/#m77e57120d230d57f34c29e1422d7fc5f5587ac30 > > Thanks > -Anand > > Anand Moon (4): > thermal/drivers/exynos: Refactor clk_sec initialization inside > SOC-specific case > thermal/drivers/exynos: Use devm_clk_get_enabled() helpers > thermal/drivers/exynos: Remove redundant IS_ERR() checks for clk_sec > clock > thermal/drivers/exynos: Fixed the efuse min max value for exynos5422 > > drivers/thermal/samsung/exynos_tmu.c | 100 ++++++++++----------------- > 1 file changed, 35 insertions(+), 65 deletions(-) > > > base-commit: b6ea1680d0ac0e45157a819c41b46565f4616186 > -- > 2.49.0 > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
