On Mon, Apr 28, 2025 at 08:35:16PM GMT, Shin Son wrote: > The CLKS_NR_CPUCL0 macro was incorrectly defined based on a wrong clock ID. > It mistakenly referenced CLK_DOUT_CLUSTER0_PERIPHCLK, which corresponds to > a cluster peripheral clock, not the last clock ID for CPUCL0 as intended. > > This patch corrects the definition to use CLK_DOUT_CPUCL0_NOCP + 1, Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > properly matching the last clock ID for CPUCL0 as intended. > > This error was due to confusion with the hardware diagram, and this patch > ensures that the number of clocks for CPUCL0 is correctly defined. Fixes: 59636ec89c2c ("clk: samsung: exynosautov920: add cpucl0 clock support") And proper order - fixes are *ALWAYS* before new features. Best regards, Krzysztof
