Re: [PATCH v1 08/10] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for Exyno5250 smdk5250

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/04/2025 15:26, Anand Moon wrote:
> The MAX77686 PMCI is able to power down and up key core supplies and other
> voltage rails via PWRREQ signal to enter / exit (deep) sleep mode.
> PWRREQ status is ignored during initial power up and down processes.
> All programming must be done before the AP enterns the sleep mode by
> pulling PWRREQ low since the AP does not have programming capability
> in (deep) sleep mode.
> 
> Add suspend-to-mem node to regulator core to be enabled or disabled
> during system suspend and also support changing the regulator operating
> mode during runtime and when the system enter sleep mode (stand by mode).
> 
> Regulators which can be turned off during system suspend:
> 	-LDOn   :       2, 6-8, 10-12, 14-16,
>         -BUCKn  :       1-4.
> Use standard regulator bindings for it ('regulator-off-in-suspend').

I do not believe you tested this but instead send whatever you found
somewhere without actually understanding the code. In the past you were
sending such patches - without knowing what they do and without actually
testing.

NAK

Best regards,
Krzysztof




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux