Re: [PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/04/2025 10:05, Thomas Antoine wrote:
> On 4/22/25 12:05, Krzysztof Kozlowski wrote:
>> On Mon, Apr 21, 2025 at 08:13:34PM GMT, Thomas Antoine wrote:
>>> +allOf:
>>> +  - $ref: power-supply.yaml#
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - maxim,max17201
>>> +    then:
>>> +      properties:
>>> +        reg:
>>> +          minItems: 2
>>> +          maxItems: 2
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - maxim,max77759-fg
>>> +    then:
>>> +      properties:
>>> +        reg:
>>> +          items:
>>> +            minItems: 1
>> If there is going to be resend, drop minItems.
>>
> Will drop it in v4.
> 
One more thing - your reg-names are now incorrectly constrained - where
are their constraints?

You need to test your bindings and DTS before you post. If by any chance
community robots found more issues (e.g. you sent something untested),
you should address it.


Best regards,
Krzysztof




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux