Re: [PATCH v3 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: André Draszik <andre.draszik@xxxxxxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>, Chanwoo Choi <cw00.choi@xxxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Michael Turquette <mturquette@xxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
Subject: Re: [PATCH v3 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits
From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Date: Sun, 6 Apr 2025 20:35:44 +0200
Cc: Peter Griffin <peter.griffin@xxxxxxxxxx>, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>, Will McVicker <willmcvicker@xxxxxxxxxx>, kernel-team@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx
In-reply-to: <20250403-s2mpg10-v3-30-b542b3505e68@linaro.org>
References: <20250403-s2mpg10-v3-0-b542b3505e68@linaro.org> <20250403-s2mpg10-v3-30-b542b3505e68@linaro.org>
User-agent: Mozilla Thunderbird

On 03/04/2025 10:59, André Draszik wrote:
> The regmap_clear_bits() and regmap_set_bits() helper macros state the
> intention a bit more obviously.
> 
> Use those.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof

References:
- [PATCH v3 00/32] Samsung S2MPG10 PMIC MFD-based drivers
  - From: André Draszik
- [PATCH v3 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits
  - From: André Draszik

Prev by Date: Re: [PATCH v3 29/32] rtc: s5m: switch to devm_device_init_wakeup
Next by Date: Re: [PATCH v3 27/32] rtc: s5m: add support for S2MPG10 RTC
Previous by thread: [PATCH v3 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits
Next by thread: [PATCH v3 22/32] mfd: sec: convert to using REGMAP_IRQ_REG() macros
Index(es):
- Date
- Thread

[Index of Archives] [Linux SoC Development] [Linux Rockchip Development] [Linux for Synopsys ARC Processors]

[Linux on Unisoc (RDA Micro) SoCs] [Linux Actions SoC] [Linux USB Development] [Video for Linux] [Linux Audio Users] [Linux SCSI] [Yosemite News]