On 02/04/2025 03:33, jiang.peng9@xxxxxxxxxx wrote: >> Same comments as with other patches, not possible, IMO. Plus this patch >> looks actually worse - commit msg is hardly readable. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > Thank you for your feedback. Let me briefly re-explain the change: No need, it was already on the lists many times. > The issue: > When building with W=1, we get a format-overflow warning because "clk_uart_baud%d" could write 15-17 bytes (14 chars + 1-3 digits) into a 15-byte buffer. > The fix: > Increased clkname buffer size from 15 to 18 chars > (original 14 chars + 3 digits + null = 18) > Replaced sprintf() with snprintf() for safety > This keeps the pattern consistent while eliminating the warning. Tested with CONFIG_SERIAL_SAMSUNG=y builds. That's not a test. Test is running on a device. Compiling is not a test. > Would you prefer any adjustments to this approach? Same comments as for previous cases. Go search other discussions. Best regards, Krzysztof
